Fix Selenium packaging in Windows executable - #6
Merged
Conversation
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows executable failed before browser startup with
No module named 'selenium.webdriver.chrome.options'. Selenium loads WebDriver modules dynamically, and the previous build commands did not bundle the complete dependency.Use one canonical PyInstaller spec to collect Selenium modules and runtime data, including Selenium Manager. Validate lazy imports at startup, stop retrying a missing dependency, and give packaged users rebuild/download guidance instead of telling them to run pip inside the EXE.
Add
Aeyori.exe --check-bundle report.jsonto verify the actual shipped runtime without opening the UI or contacting external services. Document this release check and add two regression tests for frozen/source dependency failures.Validation:
frozen: trueandok: true, including Chrome WebDriver imports and the Selenium Manager binary.Addresses #5. Leave the issue open pending confirmation with the refreshed download; a source fix alone does not update the release executable.